Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test the build output #18

Open
johannes-lindgren opened this issue Aug 26, 2024 · 0 comments
Open

Test the build output #18

johannes-lindgren opened this issue Aug 26, 2024 · 0 comments

Comments

@johannes-lindgren
Copy link
Collaborator

We should add a test that tests that the build works as expected; for example, that the exports in package.json is configured correctly.

  1. Include a new workspace package that imports immer-yjs as "immer-yjs": "file:../pure-parse",
  2. In CI/CD Build the library, then run the unit tests for this package.

If immer-yjs is configured incorrectly, the tests fails.
@johannes-lindgren johannes-lindgren mentioned this issue Aug 26, 2024
Merged
johannes-lindgren added a commit that referenced this issue Jan 23, 2025
@johannes-lindgren
ci: init automated checks (#16)
f732bc9 
Resolves #14

Adding automated checks:

For the pull requests:
- Title check: checks that the title it formatted according to the [conventional commits specs](https://www.conventionalcommits.org/en/v1.0.0/). If we would like to ensure that all commit messages are formatted as such, we could configure the repository so that only squash and merge is allowed. In that way, the title from the PR will become the commit message.

For the source code:
- Code formatting: note that this job will be failing in this PR. This is ok, since I'll address this in a separate PR.
- Type checking
- Linter
- Tests
- Build. Not very useful on its own, but the idea is that the output will be tested in another step (#18). This will require a separate PR, which is why tha

@sep2 Once this PR has been merged, I'd like to request a branch protection rule for main that requires both of these checks to pass.



## How to test

Create a new branch based on this one. Make changes, open a stacked PR, and observe the result from the automated checks:

Check that all jobs always run, even if the previous jobs failed. For example, if the code formatter fails, we still want to see if the linter fails.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@johannes-lindgren and others