-
Notifications
You must be signed in to change notification settings - Fork 11
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Resolves #14 Adding automated checks: For the pull requests: - Title check: checks that the title it formatted according to the [conventional commits specs](https://www.conventionalcommits.org/en/v1.0.0/). If we would like to ensure that all commit messages are formatted as such, we could configure the repository so that only squash and merge is allowed. In that way, the title from the PR will become the commit message. For the source code: - Code formatting: note that this job will be failing in this PR. This is ok, since I'll address this in a separate PR. - Type checking - Linter - Tests - Build. Not very useful on its own, but the idea is that the output will be tested in another step (#18). This will require a separate PR, which is why tha @sep2 Once this PR has been merged, I'd like to request a branch protection rule for main that requires both of these checks to pass. ## How to test Create a new branch based on this one. Make changes, open a stacked PR, and observe the result from the automated checks: Check that all jobs always run, even if the previous jobs failed. For example, if the code formatter fails, we still want to see if the linter fails.
- Loading branch information
1 parent
8ef2b9a
commit f732bc9
Showing
5 changed files
with
60 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
on: | ||
pull_request: | ||
types: [opened, edited, synchronize, reopened] | ||
|
||
permissions: | ||
pull-requests: read | ||
|
||
# https://github.com/amannn/action-semantic-pull-request | ||
jobs: | ||
title-check: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: amannn/action-semantic-pull-request@v5 | ||
env: | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
with: | ||
requireScope: false |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
name: 'Code Integration Checks' | ||
on: ['push'] | ||
jobs: | ||
integration-checks: | ||
runs-on: ubuntu-latest | ||
name: Code Integration Checks | ||
steps: | ||
- name: Check out | ||
uses: actions/checkout@v3 | ||
- name: Set up node | ||
uses: actions/setup-node@v3 | ||
with: | ||
node-version: 22 | ||
cache: 'yarn' | ||
registry-url: 'https://registry.npmjs.org' | ||
- name: Install | ||
run: yarn install --immutable | ||
- name: Check Code Formatting | ||
if: always() | ||
run: yarn check:formatting | ||
- name: Check Types | ||
if: always() | ||
run: yarn check:types | ||
- name: Lint | ||
if: always() | ||
run: yarn lint | ||
- name: Test | ||
if: always() | ||
run: yarn test | ||
- name: Build | ||
if: always() | ||
run: yarn build | ||
# TODO test build output: https://github.com/sep2/immer-yjs/issues/18 | ||
# - name: Test Build Output | ||
# if: always() | ||
# run: yarn workspace test-app test |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
.pnp.cjs | ||
.pnp.loader.mjs |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters