Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Sentry 24.11.2 #1640

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

@kimxogus kimxogus force-pushed the feat/sentry-24.11.2 branch from ddb671c to 6947220 Compare December 17, 2024 11:35
@patsevanton
Copy link
Contributor

@kimxogus Maybe upgrade to first 24.10.0 ?

@kimxogus
Copy link
Contributor Author

@patsevanton My PR bumps sentry to fix security vulunability which was fixed in 24.11.1.
I've tested upgrading from 24.9.0 to 24.11.1 in my test environment. and it works fine

@patsevanton
Copy link
Contributor

I search topic for 24.9.0:
https://github.com/getsentry/snuba/blob/24.9.0/snuba/utils/streams/topics.py
https://github.com/getsentry/sentry/blob/24.9.0/src/sentry/conf/server.py
I think need add some topic before upgrade image.......

@Mokto
Copy link
Contributor

Mokto commented Dec 23, 2024

The direct upgrade to 24.11 is fine. But yeah the tests need to pass.

@Mokto
Copy link
Contributor

Mokto commented Dec 23, 2024

👋 Hi, @kimxogus,
I detected conflicts against the base branch 🙊
You'll want to sync 🔄 your branch with upstream!

@kimxogus kimxogus force-pushed the feat/sentry-24.11.2 branch from 6947220 to d46d8a8 Compare December 24, 2024 04:42
@patsevanton
Copy link
Contributor

After create new release #1648 i will create PR for update to https://github.com/getsentry/sentry/releases/tag/24.10.0

@kimxogus
Copy link
Contributor Author

snuba-migrate job fails with this error.
I'll write a separete PR to bump clickhouse

------------------------------------------------------------------------------------------------------------------------
==> Logs of container sentry-11zy8tpk85-snuba-migrate-2nztt
------------------------------------------------------------------------------------------------------------------------
snuba.migrations.errors.InvalidClickhouseVersion: Snuba requires minimum Clickhouse version 23.8.11.29 (sentry-11zy8tpk85-clickhouse:9000 - 23.3.19.32)
```

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants