-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add missing sidecar and global parameter for deployments & hooks #1230
Feat: Add missing sidecar and global parameter for deployments & hooks #1230
Conversation
0696ed6
to
f655320
Compare
96b935d
to
72df97d
Compare
8285160
to
3122525
Compare
@Mokto I don't understand why the chart testing not working. There are errors about clickhouse. |
Can you please rebase your branch? A fix has been merged into develop. |
Sorry @Mokto I rebased my branch but it didn't fix it. |
That's fine, it's a different failure that @TartanLeGrand is working on. |
Yes, when have been upgrade correctly the chart to sentry 24.6.0 just rebase your PR 😉 |
Thanks @TartanLeGrand and @Mokto for the answer. |
👋 Hi, @dromadaire54, |
…update to version 24.5.0
f977bb1
to
7c76bfb
Compare
@Mokto I resolved all the conflicts and the test & lint chart working perfectly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I understand that change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah yes sorry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done @Mokto
This pull request consists to add global sidecars or volumes to all deployments including hooks. In my case, the same sidecar and volume were added in all deployments and duplicated in the values file. Furthermore, I added the missing sidecar component in the deployments and hooks level. Let me know if you are suggestions about my PR.