Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add missing sidecar and global parameter for deployments & hooks #1230

Merged
merged 7 commits into from
Dec 4, 2024

Conversation

dromadaire54
Copy link
Contributor

@dromadaire54 dromadaire54 commented Apr 19, 2024

This pull request consists to add global sidecars or volumes to all deployments including hooks. In my case, the same sidecar and volume were added in all deployments and duplicated in the values file. Furthermore, I added the missing sidecar component in the deployments and hooks level. Let me know if you are suggestions about my PR.

@dromadaire54 dromadaire54 force-pushed the add-sidecar-volume branch 2 times, most recently from 0696ed6 to f655320 Compare April 19, 2024 10:09
@dromadaire54 dromadaire54 force-pushed the add-sidecar-volume branch 4 times, most recently from 8285160 to 3122525 Compare July 10, 2024 08:51
@dromadaire54
Copy link
Contributor Author

@Mokto I don't understand why the chart testing not working. There are errors about clickhouse.

@Mokto
Copy link
Contributor

Mokto commented Jul 10, 2024

Can you please rebase your branch? A fix has been merged into develop.

@dromadaire54
Copy link
Contributor Author

Sorry @Mokto I rebased my branch but it didn't fix it.

@Mokto
Copy link
Contributor

Mokto commented Jul 11, 2024

That's fine, it's a different failure that @TartanLeGrand is working on.

@TartanLeGrand
Copy link
Contributor

Yes, when have been upgrade correctly the chart to sentry 24.6.0 just rebase your PR 😉

@dromadaire54
Copy link
Contributor Author

Thanks @TartanLeGrand and @Mokto for the answer.

@Mokto
Copy link
Contributor

Mokto commented Oct 25, 2024

👋 Hi, @dromadaire54,
I detected conflicts against the base branch 🙊
You'll want to sync 🔄 your branch with upstream!

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@dromadaire54
Copy link
Contributor Author

@Mokto I resolved all the conflicts and the test & lint chart working perfectly.

@Mokto Mokto removed the conflicts label Dec 4, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand that change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes sorry

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done @Mokto

@Mokto Mokto merged commit ac8143f into sentry-kubernetes:develop Dec 4, 2024
2 of 3 checks passed
@Mokto Mokto mentioned this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants