Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: checksum only for configmap contents #1228

Merged
merged 6 commits into from
May 7, 2024

Conversation

kimxogus
Copy link
Contributor

Checksum for configmap-{COMPONENT}.yaml file contains chart: "{{ .Chart.Name }}-{{ .Chart.Version | replace "+" "_" }}" label which makes checksum to be changed in every helm chart version bump.
This makes all the deployments rollout in every helm chart bump even there's no actual change in any manifests.

This change will make checksum changes only when actual config content is updated.

@kimxogus
Copy link
Contributor Author

kimxogus commented May 2, 2024

@Mokto Could you review this PR?

@Mokto
Copy link
Contributor

Mokto commented May 7, 2024

Thanks.

@Mokto Mokto merged commit 97829b0 into sentry-kubernetes:develop May 7, 2024
2 checks passed
@Mokto Mokto mentioned this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants