Skip to content

Handle checkout failure and propagate error message #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -344,19 +344,36 @@
public void onResponse(@NotNull Call call, @NotNull Response response) throws IOException {
progressDialog.dismiss();
boolean success = response.isSuccessful();
response.close();
if (!success) {
Log.d("checkout", "response failed");
getActivity().runOnUiThread(new Runnable() {
@Override
public void run() {
progressDialog.dismiss();

processDeliveryItem(checkoutTransaction);

checkoutTransaction.finish(SpanStatus.INTERNAL_ERROR);
}
});
String errorBody = response.body() != null ? response.body().string() : "";
response.close();

Check warning on line 350 in app/src/main/java/com/example/vu/android/empowerplant/MainFragment.java

View check run for this annotation

Codecov / codecov/patch

app/src/main/java/com/example/vu/android/empowerplant/MainFragment.java#L350

Added line #L350 was not covered by tests
try {
JSONObject errorJson = new JSONObject(errorBody);
final String errorMessage = errorJson.optString("message", "Checkout failed");
getActivity().runOnUiThread(new Runnable() {

Check warning on line 354 in app/src/main/java/com/example/vu/android/empowerplant/MainFragment.java

View check run for this annotation

Codecov / codecov/patch

app/src/main/java/com/example/vu/android/empowerplant/MainFragment.java#L352-L354

Added lines #L352 - L354 were not covered by tests
@Override
public void run() {
progressDialog.dismiss();

Check warning on line 357 in app/src/main/java/com/example/vu/android/empowerplant/MainFragment.java

View check run for this annotation

Codecov / codecov/patch

app/src/main/java/com/example/vu/android/empowerplant/MainFragment.java#L357

Added line #L357 was not covered by tests

processDeliveryItem(checkoutTransaction, errorMessage);

Check warning on line 359 in app/src/main/java/com/example/vu/android/empowerplant/MainFragment.java

View check run for this annotation

Codecov / codecov/patch

app/src/main/java/com/example/vu/android/empowerplant/MainFragment.java#L359

Added line #L359 was not covered by tests

checkoutTransaction.finish(SpanStatus.INTERNAL_ERROR);
}

Check warning on line 362 in app/src/main/java/com/example/vu/android/empowerplant/MainFragment.java

View check run for this annotation

Codecov / codecov/patch

app/src/main/java/com/example/vu/android/empowerplant/MainFragment.java#L361-L362

Added lines #L361 - L362 were not covered by tests
});
} catch (JSONException e) {
Log.e("checkout", "Failed to parse error response: " + errorBody);
getActivity().runOnUiThread(new Runnable() {

Check warning on line 366 in app/src/main/java/com/example/vu/android/empowerplant/MainFragment.java

View check run for this annotation

Codecov / codecov/patch

app/src/main/java/com/example/vu/android/empowerplant/MainFragment.java#L364-L366

Added lines #L364 - L366 were not covered by tests
@Override
public void run() {
progressDialog.dismiss();
processDeliveryItem(checkoutTransaction, "Checkout failed");
checkoutTransaction.finish(SpanStatus.INTERNAL_ERROR);
}

Check warning on line 372 in app/src/main/java/com/example/vu/android/empowerplant/MainFragment.java

View check run for this annotation

Codecov / codecov/patch

app/src/main/java/com/example/vu/android/empowerplant/MainFragment.java#L369-L372

Added lines #L369 - L372 were not covered by tests
});
}
} else {
response.close();

Check warning on line 376 in app/src/main/java/com/example/vu/android/empowerplant/MainFragment.java

View check run for this annotation

Codecov / codecov/patch

app/src/main/java/com/example/vu/android/empowerplant/MainFragment.java#L374-L376

Added lines #L374 - L376 were not covered by tests
}
}

Expand Down Expand Up @@ -410,12 +427,12 @@
return postBody;
}

private void processDeliveryItem(ITransaction checkoutTransaction) {
private void processDeliveryItem(ITransaction checkoutTransaction, String errorMessage) {
Log.i("processDeliveryItem", "processDeliveryItem >>>");
ISpan processDeliverySpan = checkoutTransaction.startChild("task", "process delivery");

try {
throw new MainFragment.BackendAPIException("Failed to init delivery workflow");
throw new MainFragment.BackendAPIException(errorMessage);

Check warning on line 435 in app/src/main/java/com/example/vu/android/empowerplant/MainFragment.java

View check run for this annotation

Codecov / codecov/patch

app/src/main/java/com/example/vu/android/empowerplant/MainFragment.java#L435

Added line #L435 was not covered by tests
} catch (Exception e) {
Log.e("processDeliveryItem", e.getMessage());
processDeliverySpan.setThrowable(e);
Expand All @@ -429,6 +446,10 @@
processDeliverySpan.finish();
Log.i("processDeliveryItem", "<<< processDeliveryItem");
}

private void processDeliveryItem(ITransaction checkoutTransaction) {
processDeliveryItem(checkoutTransaction, "Failed to init delivery workflow");
}

Check warning on line 452 in app/src/main/java/com/example/vu/android/empowerplant/MainFragment.java

View check run for this annotation

Codecov / codecov/patch

app/src/main/java/com/example/vu/android/empowerplant/MainFragment.java#L451-L452

Added lines #L451 - L452 were not covered by tests

class BackendAPIException extends RuntimeException {

Expand Down