New Feature: Failed Mode

[Seji64]

Added 'failed' Mode. This Mode checks all systemd service and reports only CRITICAL if any service has state "failed". I added the cause i wanted to monitor all my services on my linux (EL7) Hosts.

The name "failed mode" may not be the best - but I couldn't think of anything better. Maybe someone's got a better idea.

This is my first modification of a Ruby Script - hope my code is not too ugly....

Pull Request Checklist

Is this in reference to an existing issue?
No

General

• Update Changelog following the conventions laid out here

• Update README with any necessary configuration snippets

- [] Binstubs are created if needed

• RuboCop passes

- [] Existing tests pass

Purpose

Known Compatibility Issues

[majormoses]

Thanks for your contribution to Sensu plugins! Without people like you submitting PRs we couldn't run the project. I will review it shortly.

[majormoses]

This looks pretty sane, can you please include a manual or automated testing artifact?

I appeased the cops for you.

[Seji64]

Thanks for fixing the cops.
I wrote a manual test artifact...did this the first time - hope its ok.
https://gist.github.com/Seji64/748548f1a47d5baf583533bfe3a83081

While writing this gist i also noticed that the 3rd test fails. I will have a look at that.

[Seji64]

I can't get the 'next if' clause. it seems like the condition after the OR is not evaluated.

next if !( @services.any? { |service| line_array[0].include?(service) } ) || ( @failed_ignore.any? { |service| line_array[0].include?(service) } && @failed == true )
      service_hash = {}
      service_hash['name'] = line_array[0]
      service_hash['load'] = line_array[1]
      service_hash['active'] = line_array[2]
      service_hash['sub'] = line_array[3]
      service_hash['description'] = line_array[4]
      service_array.push(service_hash)
    end

Maybe you could help?

[majormoses]

I wrote a manual test artifact...did this the first time - hope its ok.

This is perfect.

While writing this gist i also noticed that the 3rd test fails. I will have a look at that.

If I look at the next test it shows they are not present, which matches what I have locally, if the service does indeed exist can you include the output of service pdns status?

I can't get the 'next if' clause. it seems like the condition after the OR is not evaluated.

I will take a look.

[majormoses]

I am confused why is there a patch file in the PR and did you still need my help figuring the code? In the actual check I dont see that line of code which it looks like you deleted here