Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin nokogiri version and remove support for ruby-2.3 #387

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

phumpal
Copy link

@phumpal phumpal commented Jan 6, 2021

Pull Request Checklist

Is this in reference to an existing issue?
No

General

  • Update Changelog following the conventions laid out here

  • Update README with any necessary configuration snippets

  • Binstubs are created if needed

  • RuboCop passes

  • Existing tests pass

New Plugins

  • Tests

  • Add the plugin to the README

  • Does it have a complete header as outlined here

Purpose

Fixes an issue where installation fails with

ERROR:  Error installing sensu-plugins-aws:
	The last version of nokogiri (>= 1.10.4, < 2.0) to support your Ruby & RubyGems was 1.10.10. Try installing it with `gem install nokogiri -v 1.10.10` and then running the current command again
	nokogiri requires Ruby version >= 2.5, < 3.1.dev. The current ruby version is 2.4.10.364.

Known Compatibility Issues

Pinning nokogiri version prevents errors when installing the Gem in
custom environments. e.g.

ERROR:  Error installing sensu-plugins-aws:
	The last version of nokogiri (>= 1.10.4, < 2.0) to support your
	Ruby & RubyGems was 1.10.10. Try installing it with `gem install nokogiri -v 1.10.10`
	and then running the current command again
	nokogiri requires Ruby version >= 2.5, < 3.1.dev. The current ruby version is 2.4.10.364.
@phumpal
Copy link
Author

phumpal commented Feb 5, 2021

Gentle ping... :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant