Change MacAddr to hold u64 instead of byte array #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oherrala
force-pushed
the
u64-macaddr
branch
2 times, most recently
from
8a54c80 to
db4f546
Compare
jtt
reviewed
Feb 6, 2025
luomu-common/src/macaddr.rs
Outdated
| &val.0 | ||
| impl From<&[u8; 6]> for MacAddr { | ||
| fn from(v: &[u8; 6]) -> Self { | ||
| let r = (u64::from(v[0]) << 40) |
There was a problem hiding this comment.
Are you sure this works on both little and big endian platforms..
Compiler probably does this anyway. And this way we can have access to upper two bytes if we want to.
jtt
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiler probably does this anyway. And this way we can have access to upper two bytes if we want to.