Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look into SRGB vs. UNORM in color descriptions. #289

Open
russell-taylor opened this issue Jan 12, 2017 · 1 comment
Open

Look into SRGB vs. UNORM in color descriptions. #289

russell-taylor opened this issue Jan 12, 2017 · 1 comment

Comments

@russell-taylor
Copy link
Contributor

Ryan writes in a pull request: So here, unlike in other code I've recently looked at, we're using the description to determine the format of the view, which seems reasonable - should we be doing that elsewhere?

Also, do we know that UNORM is the way to go here, or is SRGB sometimes the answer? Do we need to establish a convention? (For instance I'm pretty sure Oculus assumes you're handing over SRGB textures) I'm not fully versed in d3d11 and color space interactions, or how mapping occurs (what happens when you have a wide-gamut HMD, beyond just SRGB, at some point? Adobe RGB isn't that unusual, though full coverage of Adobe RGB is.)

Would be curious to find out what a renderTextureResourceView->GetDesc() call when passing nullptr would return - that would presumably tell us the difference. https://msdn.microsoft.com/en-us/library/windows/desktop/ff476629(v=vs.85).aspx

@rpavlik
Copy link
Member

rpavlik commented Aug 2, 2017

It also appears that UNORM vs SRGB is a matter of linear vs gamma space...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants