Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Update float-cmp requirement from ^0.9.0 to ^0.10.0 #19

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 23, 2024

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file rust Pull requests that update Rust code labels Sep 23, 2024
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.43%. Comparing base (9557faa) to head (e946a02).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #19   +/-   ##
=======================================
  Coverage   87.43%   87.43%           
=======================================
  Files          19       19           
  Lines         382      382           
=======================================
  Hits          334      334           
  Misses         48       48           
Flag Coverage Δ
doc 28.53% <ø> (ø)
lib 86.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Benchmark for e804066

Click to view benchmark
Test Base PR %
check if point outside ellipse 3.4±0.06ns 3.4±0.05ns 0.00%
check if point outside ellipse, but within bbox 7.0±0.13ns 7.0±0.12ns 0.00%
check if point within ellipse 7.0±0.22ns 7.0±0.32ns 0.00%
distance to point outside ellipse, but within bbox 159.6±1.46ns 160.1±6.05ns +0.31%

@leon0399
Copy link
Member

leon0399 commented Nov 1, 2024

@dependabot rebase

Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 1, 2024

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@leon0399
Copy link
Member

leon0399 commented Nov 1, 2024

@dependabot recreate

---
updated-dependencies:
- dependency-name: float-cmp
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/cargo/float-cmp-tw-0.10.0 branch from 682feba to e946a02 Compare November 1, 2024 21:28
Copy link

github-actions bot commented Nov 1, 2024

Benchmark for 6f692f9

Click to view benchmark
Test Base PR %
check if point outside ellipse 3.4±0.05ns 3.4±0.05ns 0.00%
check if point outside ellipse, but within bbox 6.9±0.10ns 6.9±0.14ns 0.00%
check if point within ellipse 7.0±0.37ns 6.9±0.06ns -1.43%
distance to point outside ellipse, but within bbox 158.9±0.91ns 159.1±0.73ns +0.13%

Copy link

github-actions bot commented Nov 1, 2024

Benchmark for f5be1e7

Click to view benchmark
Test Base PR %
check if point outside ellipse 3.4±0.05ns 3.4±0.03ns 0.00%
check if point outside ellipse, but within bbox 6.9±0.15ns 6.9±0.15ns 0.00%
check if point within ellipse 6.9±0.26ns 6.9±0.27ns 0.00%
distance to point outside ellipse, but within bbox 158.5±0.93ns 159.2±0.52ns +0.44%

@leon0399 leon0399 merged commit 5808b27 into master Nov 1, 2024
17 checks passed
@leon0399 leon0399 deleted the dependabot/cargo/float-cmp-tw-0.10.0 branch November 1, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant