-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review and test classification #106
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #106 +/- ##
==========================================
- Coverage 63.04% 62.33% -0.72%
==========================================
Files 63 65 +2
Lines 2073 2156 +83
==========================================
+ Hits 1307 1344 +37
- Misses 766 812 +46 ☔ View full report in Codecov by Sentry. |
3ed0b60
to
9fab779
Compare
I believe this as is might fail with GPU models but can test in colab later. Have been making some changes to these functions in jordan_060 but can definitely merge some of these changes together. also I think batching should possibly be done slightly differently but this is likely a larger conversation with @fabiocat93 next week on how to incorporate best with Pydra. otherwise looks good |
Ah, okay, we'll discuss next week then |
@ibevers i see you self-assigned the review of audio classification and started working on it. is there anything else that you think should be done in terms of documentation, tutorial, testing, code optimization? |
@fabiocat93 @wilke0818 We still need to discuss the batching approach here. Also, this needs a tutorial. To-dos:
|
@wilke0818 @ibevers how do you intend to proceed with this? is there any progress update? |
we never really discussed batching so I don't have any updates. I have a tutorial I can upload at some point for speech emotion recognition |
would be great. thanks! at least to have it there if someone needs it (even if not optimized) |
This PR is for reviewing, updating, and adding tests to the classification.