Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and test classification #106

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ibevers
Copy link
Collaborator

@ibevers ibevers commented Jul 16, 2024

This PR is for reviewing, updating, and adding tests to the classification.

@ibevers ibevers self-assigned this Jul 16, 2024
@ibevers ibevers linked an issue Jul 16, 2024 that may be closed by this pull request
2 tasks
@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2024

Codecov Report

Attention: Patch coverage is 9.09091% with 40 lines in your changes missing coverage. Please review.

Project coverage is 62.33%. Comparing base (f3c595f) to head (9fab779).
Report is 28 commits behind head on main.

Files Patch % Lines
src/tests/audio/tasks/classification_test.py 5.40% 35 Missing ⚠️
...tasks/classification/speech_emotion_recognition.py 28.57% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #106      +/-   ##
==========================================
- Coverage   63.04%   62.33%   -0.72%     
==========================================
  Files          63       65       +2     
  Lines        2073     2156      +83     
==========================================
+ Hits         1307     1344      +37     
- Misses        766      812      +46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ibevers ibevers requested a review from wilke0818 July 19, 2024 21:45
@ibevers ibevers marked this pull request as ready for review July 19, 2024 21:47
@ibevers ibevers force-pushed the 103-task-classification-peer-review-and-testing branch from 3ed0b60 to 9fab779 Compare July 19, 2024 21:48
@wilke0818
Copy link
Collaborator

I believe this as is might fail with GPU models but can test in colab later. Have been making some changes to these functions in jordan_060 but can definitely merge some of these changes together. also I think batching should possibly be done slightly differently but this is likely a larger conversation with @fabiocat93 next week on how to incorporate best with Pydra. otherwise looks good

@ibevers
Copy link
Collaborator Author

ibevers commented Jul 19, 2024

Ah, okay, we'll discuss next week then

@fabiocat93
Copy link
Collaborator

@ibevers i see you self-assigned the review of audio classification and started working on it. is there anything else that you think should be done in terms of documentation, tutorial, testing, code optimization?

@ibevers
Copy link
Collaborator Author

ibevers commented Aug 13, 2024

@ibevers i see you self-assigned the review of audio classification and started working on it. is there anything else that you think should be done in terms of documentation, tutorial, testing, code optimization?

@fabiocat93 @wilke0818 We still need to discuss the batching approach here. Also, this needs a tutorial.

To-dos:

  • Determine whether batching approach makes sense, change if necessary, and test
  • Add tutorial

@fabiocat93
Copy link
Collaborator

@wilke0818 @ibevers how do you intend to proceed with this? is there any progress update?

@wilke0818
Copy link
Collaborator

we never really discussed batching so I don't have any updates. I have a tutorial I can upload at some point for speech emotion recognition

@fabiocat93
Copy link
Collaborator

we never really discussed batching so I don't have any updates. I have a tutorial I can upload at some point for speech emotion recognition

would be great. thanks! at least to have it there if someone needs it (even if not optimized)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task: classification peer review and testing
4 participants