CI: Build with build #49
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #49 +/- ##
=======================================
Coverage 83.56% 83.56%
=======================================
Files 3 3
Lines 73 73
=======================================
Hits 61 61
Misses 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
effigies
force-pushed
the
mnt/build
branch
2 times, most recently
from
303b8fd
to
581b9fa
Compare
|
I trust you on this @effigies ! but now we need a rebase due to dependabot changes have been merged |
|
Would it make sense to run this on all PR/push and just condition the publish step on release? |
|
Did it anyway. Now no need to trust. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
python setup.pydirectly is deprecated. Using a dedicated build tool likebuildis the thing now. Also switched to pipx to bypass the install step; pipx will ensure the tools we directly use get installed and build will ensure the build-time dependencies get installed.