Skip to content

Commit

Permalink
Merge pull request #4 from sensein/dev
Browse files Browse the repository at this point in the history
Dev
  • Loading branch information
fabiocat93 authored Sep 17, 2024
2 parents 4960206 + 3bbb858 commit 0f5ab9c
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 16 deletions.
9 changes: 4 additions & 5 deletions .github/workflows/macos_tests.yaml
Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@
name: macOS Tests
name: macOS-tests

on:
pull_request:

workflow_dispatch:
jobs:
macos-tests:
if: contains(github.event.pull_request.labels.*.name, 'release')
name: macOS Tests
name: macOS-tests
runs-on: ${{ matrix.os }}
strategy:
fail-fast: true
Expand Down
19 changes: 8 additions & 11 deletions .github/workflows/ubuntu_tests.yaml
Original file line number Diff line number Diff line change
@@ -1,18 +1,15 @@
name: ubuntu Tests
name: ubuntu-tests

on:
pull_request:

# on:
# workflow_run:
# workflows: ["macOS Tests"]
# types:
# - completed
workflow_run:
workflows: ["macOS-tests"]
types:
- completed

jobs:
start-runner:
# if: ${{ github.event.workflow_run.conclusion == 'success' }} # Trigger only if macOS tests succeed
name: Start self-hosted EC2 runner for GPU
name: start-runner
runs-on: ubuntu-latest
outputs:
label: ${{ steps.start-ec2-runner.outputs.label }}
Expand All @@ -36,7 +33,7 @@ jobs:
security-group-id: ${{ vars.AWS_SECURITY_GROUP }}

ubuntu-tests:
name: Run GPU Tests on the runner
name: ubuntu-tests
needs: start-runner
runs-on: ${{ needs.start-runner.outputs.label }}
strategy:
Expand Down Expand Up @@ -87,7 +84,7 @@ jobs:
shell: bash

stop-runner:
name: Stop self-hosted EC2 runner
name: stop-runner
needs:
- start-runner # waits for the EC2 instance to be created
- ubuntu-tests # waits for the actual job to finish
Expand Down

0 comments on commit 0f5ab9c

Please sign in to comment.