Skip to content

Commit

Permalink
chore: update some code quality
Browse files Browse the repository at this point in the history
  • Loading branch information
senkenn committed Jun 22, 2024
1 parent eef29ca commit 03ae3ec
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion .vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
},
"rust-analyzer.linkedProjects": [
"./sql-extraction/rs/Cargo.toml",
"./vsce/test-workspace-rs/Cargo.toml"
"./vsce-test/test-workspace-rs/Cargo.toml"
],
"github-actions.workflows.pinned.workflows": [
".github/workflows/e2e-test.yaml",
Expand Down
8 changes: 5 additions & 3 deletions biome.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,17 +17,19 @@
"rules": {
"recommended": true,
"suspicious": {
"noExplicitAny": "warn"
"noExplicitAny": "warn",
"noConsoleLog": "error"
},
"style": {
"noParameterAssign": "warn",
"noNonNullAssertion": "warn"
}
}
},
"ignore": ["test-workspace*"]
},
"json": {
"parser": {
"allowTrailingCommas": false,
"allowTrailingCommas": true,
"allowComments": true
}
}
Expand Down
4 changes: 2 additions & 2 deletions lefthook.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@ pre-commit:
biome:
glob: "*.{js,ts,jsx,tsx,json,css,scss}"
run: |
bunx biome check --apply {staged_files} && git add {staged_files}
pnpm biome check --apply {staged_files} && git add {staged_files}
cspell:
glob: "*"
run: |
# check file name
git diff --name-only --cached | bunx cspell --no-progress --show-context stdin --cache
git diff --name-only --cached | pnpm cspell --no-progress --show-context stdin --cache
1 change: 0 additions & 1 deletion vsce-test/test/suite-ts/extension.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ afterEach(async () => {
describe("Install sqls if not found in PATH", () => {
test("Should find sqls in PATH", async () => {
const sqlsVersion = execSync("sqls --version").toString();
console.log(sqlsVersion);
expect(sqlsVersion).not.toBe("");
});
});
Expand Down
1 change: 0 additions & 1 deletion vsce/src/extension.ts
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,6 @@ export async function activate(context: vscode.ExtensionContext) {
config = undefined;
}
sqlNodes = await extractSqlListRs(rawContent, config?.configs);
console.log(sqlNodes);
break;
}
default:
Expand Down

0 comments on commit 03ae3ec

Please sign in to comment.