Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php-compatibility: Improve compatibility with PHP versions #25

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

sinukaarel
Copy link
Collaborator

This PR fixes a mistakenly added named argument in function call. This was probably caused due to a not intentional double-click on the variable. To mitigate the issue I have set editor inlay hints to be visible only when holding ctrl + alt keys.

As the issue came out with PHPCompatibility rule that has not landed in any of the master versions. I scanned the codebase with the development branch of the package. I also fixed issues that came out regarding php 8.1 compatibility.

This PR fixes a mistakenly added named argument in function call. This was probably caused due to a not intentional double-click on the variable. To mitigate the issue I have set editor inlay hints to be visible only when holding ctrl + alt keys.

As the issue came out with PHPCompatibility rule that has not landed in any of the master versions. I scanned the codebase with the `development` branch of the package. I also fixed issues that came out regarding php 8.1 compatibility.
@sinukaarel sinukaarel added the maintenance House keeping label Jan 27, 2025
@sinukaarel sinukaarel self-assigned this Jan 27, 2025
@sinukaarel sinukaarel merged commit 29fc553 into main Jan 27, 2025
1 check passed
@sinukaarel sinukaarel deleted the kaarel/pro-13-issues-from-plugin-check-pcp branch January 27, 2025 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance House keeping
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant