Merge pull request #198 from sendsmaily/release/3.0.x-1.5.2

Release 1.5.2 for 3.0.x
sendsmaily · Jan 27, 2021 · 8b6d3eb · 8b6d3eb
2 parents f60a848 + 800cf40
commit 8b6d3eb
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 7 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,10 @@
 # Changelog
 
+### 1.5.2
+
+- Fix undefined index error for RSS product limit - [[#190](https://github.com/sendsmaily/smaily-opencart-module/issues/190)]
+- Fix validation error not showing if RSS product limit higher than 250 - [[#193](https://github.com/sendsmaily/smaily-opencart-module/pull/193)]
+
 ### 1.5.1
 
 - Fix RSS feed not displaying product title and description correctly - [[#167](https://github.com/sendsmaily/smaily-opencart-module/issues/167)]

diff --git a/install.xml b/install.xml
@@ -2,7 +2,7 @@
 <modification>
     <code>smaily_for_opencart_extension</code>
     <name>Smaily for OpenCart</name>
-    <version>1.5.1</version>
+    <version>1.5.2</version>
     <author>Smaily</author>
     <link>https://github.com/sendsmaily/smaily-opencart-module</link>
 </modification>
diff --git a/upload/admin/controller/extension/module/smaily_for_opencart.php b/upload/admin/controller/extension/module/smaily_for_opencart.php
@@ -11,7 +11,7 @@
  *
  * Plugin Name: Smaily for OpenCart
  * Description: Smaily email marketing and automation extension plugin for OpenCart.
- * Version: 1.5.1
+ * Version: 1.5.2
  * License: GPL3
  * Author: Smaily
  * Author URI: https://smaily.com/
@@ -32,7 +32,7 @@
 require_once(DIR_SYSTEM . 'library/smailyforopencart/request.php');
 class ControllerExtensionModuleSmailyForOpencart extends Controller {
     private $error = array();
-    private $version = '1.5.1';
+    private $version = '1.5.2';
 
     public function index() {
         // Add language file.
@@ -571,10 +571,10 @@ protected function validate() {
         }
 
         // Validate RSS product limit value
-        if (isset($this->request->post['smaily_for_opencart_rss_limit'])
-        && (int) $this->request->post['smaily_for_opencart_rss_limit'] < 1
-        || (int) $this->request->post['smaily_for_opencart_rss_limit'] > 250
-        ) {
+        if (isset($this->request->post['module_smaily_for_opencart_rss_limit'])
+        &&  ((int) $this->request->post['module_smaily_for_opencart_rss_limit'] < 1
+        || (int) $this->request->post['module_smaily_for_opencart_rss_limit'] > 250
+        )) {
             $this->error['rss_limit'] = $this->language->get('rss_limit_error');
         }
         return !$this->error;