Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support no-restart flag for clickhouse_user_files #33

Merged
merged 4 commits into from
Dec 8, 2024

Conversation

brazhin
Copy link
Contributor

@brazhin brazhin commented Dec 4, 2024

Closes #32

Copy link
Collaborator

@azat azat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM.

Can you also:

  • add a test
  • adjust advanced article to reflect that it is also supported

@azat azat self-assigned this Dec 4, 2024
@brazhin
Copy link
Contributor Author

brazhin commented Dec 8, 2024

Thank you! LGTM.

Can you also:

  • add a test
  • adjust advanced article to reflect that it is also supported

Added a test and expanded the article

molecule/default/inventory/group_vars/all.yml Show resolved Hide resolved
Documentation/Advanced_Configuration.md Outdated Show resolved Hide resolved
Documentation/Advanced_Configuration.md Outdated Show resolved Hide resolved
@@ -42,6 +42,10 @@ clickhouse_user_files:
- users.d/01-first_test_user.yml
- file: users.d/02-second_test_user.yml
no_log: true
- file: users.d/03-third_test_user.yml
# TODO: properly test that attributes are supported
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests for attributes does not work now, but OK, they were never worked so I will merge it as-is

If you will be interested - #34 (this will be very welcome!)

@azat azat merged commit c78692b into semrush:main Dec 8, 2024
6 checks passed
@azat
Copy link
Collaborator

azat commented Dec 8, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to avoid restarts on users configuration changes
2 participants