Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove flat-head #49

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

suchapalaver
Copy link
Contributor

@suchapalaver suchapalaver commented Nov 5, 2024

Removing flat-head to prioritize releasing a library for pre-merge verifiable extraction. It provides an interesting example of using our decoder and header accumulator crates, but it's essentially an app that uses them rather than a logical part of the library.

We do have ideas to use the S3 interface in the decoder Reader:

@suchapalaver suchapalaver self-assigned this Nov 5, 2024
Copy link

linear bot commented Nov 5, 2024

BACK-141 remove `flat-head` from `veemon`

joseph said in BACK-72:

I suggest we remove flat-head from veemon. We should archive the code somewhere as it might have some useful solutions for specific user cases such as S3 buckets. We could make another example out of the code.

We should make flat-head a private repo in semiotic-ai in case we want to use any of the store solutions.

@suchapalaver suchapalaver force-pushed the joseph/back-68-clean-up-flat-files-decoder branch 10 times, most recently from cb1aa47 to b0e65b9 Compare November 6, 2024 03:31
Base automatically changed from joseph/back-68-clean-up-flat-files-decoder to main November 6, 2024 14:08
@suchapalaver suchapalaver force-pushed the joseph/back-141-remove-flat-head-from-veemon branch 2 times, most recently from 864b723 to e13c6eb Compare November 6, 2024 14:15
@suchapalaver suchapalaver marked this pull request as ready for review November 6, 2024 14:28
@suchapalaver suchapalaver force-pushed the joseph/back-141-remove-flat-head-from-veemon branch from e13c6eb to a33e691 Compare November 6, 2024 14:32
@pedrohba1
Copy link
Contributor

The Store approach seems to make more sense, just to clarify it would be based on the store.rs that was on flat_head.

@suchapalaver suchapalaver merged commit 2f10eb3 into main Nov 6, 2024
9 checks passed
@suchapalaver suchapalaver deleted the joseph/back-141-remove-flat-head-from-veemon branch November 6, 2024 15:05
@suchapalaver
Copy link
Contributor Author

The Store approach seems to make more sense, just to clarify it would be based on the store.rs that was on flat_head.

I think we're talking about the same thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants