Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up flat files decoder #48

Merged
merged 2 commits into from
Nov 6, 2024
Merged

clean up flat files decoder #48

merged 2 commits into from
Nov 6, 2024

Conversation

suchapalaver
Copy link
Contributor

No description provided.

@suchapalaver suchapalaver self-assigned this Nov 4, 2024
@linear Linear
Copy link

linear bot commented Nov 4, 2024

BACK-68 Clean up `flat-files-decoder`

Clean up the flat-files-decoder crate. Do not add new features.

  • Any new public functions should be tested.
  • Any new public functions should be documented.

You are responsible for propagating any name changes you make.

@suchapalaver suchapalaver force-pushed the joseph/back-68-clean-up-flat-files-decoder branch 2 times, most recently from 1b354ec to 0513e38 Compare November 4, 2024 22:18
@suchapalaver suchapalaver marked this pull request as ready for review November 4, 2024 22:30
@suchapalaver suchapalaver force-pushed the joseph/back-68-clean-up-flat-files-decoder branch 5 times, most recently from adc0cc3 to ffe644d Compare November 5, 2024 21:25
@suchapalaver suchapalaver force-pushed the joseph/back-68-clean-up-flat-files-decoder branch from ffe644d to ba0feaa Compare November 5, 2024 21:29
gusinacio
gusinacio reviewed Nov 5, 2024
View reviewed changes
Copy link
Contributor

@gusinacio gusinacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, request again my review when you are ready.

pedrohba1
pedrohba1 reviewed Nov 5, 2024
View reviewed changes
crates/flat-files-decoder/Cargo.toml Outdated Show resolved Hide resolved
crates/flat-files-decoder/tests/decode.rs Outdated Show resolved Hide resolved
@suchapalaver suchapalaver force-pushed the joseph/back-68-clean-up-flat-files-decoder branch from ba0feaa to 986f5e5 Compare November 5, 2024 22:48
@suchapalaver suchapalaver force-pushed the joseph/back-68-clean-up-flat-files-decoder branch 3 times, most recently from a72454d to e2fc30e Compare November 6, 2024 03:15
@suchapalaver suchapalaver force-pushed the joseph/back-68-clean-up-flat-files-decoder branch 6 times, most recently from c4f58e3 to cb1aa47 Compare November 6, 2024 03:27
@suchapalaver suchapalaver force-pushed the joseph/back-68-clean-up-flat-files-decoder branch from cb1aa47 to b0e65b9 Compare November 6, 2024 03:31
@suchapalaver suchapalaver merged commit 6ee0128 into main Nov 6, 2024
9 checks passed
@suchapalaver suchapalaver deleted the joseph/back-68-clean-up-flat-files-decoder branch November 6, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrohba1 pedrohba1 pedrohba1 approved these changes

@gusinacio gusinacio Awaiting requested review from gusinacio

Assignees

@suchapalaver suchapalaver

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@suchapalaver @gusinacio @pedrohba1