This repository has been archived by the owner on Nov 19, 2024. It is now read-only.
Move bench files #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@severiano-sisneros sending this message to see if github extension for slack works to notify you. |
@pedrohba1 doesn't look like I was notified in slack... |
severiano-sisneros
approved these changes
Feb 16, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bench files were being pulled when using as a dependency so I moved them to tests folder where this won't happen. Making the life of anyone using flat_files_decoder as dependency easier on the internet download. Also, I've added more details about this code on README.md
@severiano-sisneros can you check the TODO's in this code? I've written them in the key parts of the doc that I was not entirely sure on.