Skip to content

RFC: Update to VkFFT 1.3.4 and Vulkano 0.34.1, multiplatform support #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 35 commits into
base: master
Choose a base branch
from

Conversation

NickKarpowicz
Copy link

I worked a bit on updating the library to do a few things that I needed:

  • Uses the newest version of VkFFT, after the refactoring into multiple headers
  • Uses the newer version of Vulkano (with substantial changes in how buffers are made and command buffers submitted)
  • Ability to set newer VkFFT options like DCT and DST mode
  • Runs on MacOS and Windows in addition to Linux
  • Minimal additional build steps required by including glslang and VkFFT as git submodules
  • Dependencies (except for libvulkan and a C/C++ compiler) built via cargo
  • Example code that makes it (hopefully) a bit easier to understand the data layout and operations

This did lead to a fairly large number of changes since Vulkano has changed a lot in the past two years, so I apologize for the rather large PR; it turned out more involved than I expected. I tried to be descriptive in the commit messages, but if anything is unclear, please let me know - I'm happy for any feedback you might have!

NickKarpowicz and others added 30 commits August 11, 2024 08:57
@NickKarpowicz NickKarpowicz marked this pull request as ready for review September 15, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant