-
Notifications
You must be signed in to change notification settings - Fork 4
RFC: Update to VkFFT 1.3.4 and Vulkano 0.34.1, multiplatform support #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
NickKarpowicz
wants to merge
35
commits into
semio-ai:master
Choose a base branch
from
NickKarpowicz:Update_to_1_3_4
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…added single_fft fn
…plify creation of buffers
…ction so that MacOS via MoltenVK works
…tions, only the ones that are exported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I worked a bit on updating the library to do a few things that I needed:
This did lead to a fairly large number of changes since Vulkano has changed a lot in the past two years, so I apologize for the rather large PR; it turned out more involved than I expected. I tried to be descriptive in the commit messages, but if anything is unclear, please let me know - I'm happy for any feedback you might have!