Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: only show sign in/out as relevant #187

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Conversation

kopecs
Copy link
Contributor

@kopecs kopecs commented Nov 22, 2024

This uses the new context key for login status. However, since that context key is still frequently stale due how the current login flow works with our LSP extensions, we should hold off on merging this one until I clean that up too.

PR checklist:

  • Purpose of the code is evident to future readers
  • Tests included or PR comment includes a reproducible test plan
  • Documentation is up-to-date
  • A changelog entry was for any user-facing change
  • Change has no security implications (otherwise, ping security team)

If you're unsure about any of this, please see:

@kopecs kopecs marked this pull request as ready for review December 2, 2024 20:14
@kopecs kopecs marked this pull request as draft December 2, 2024 20:15
@kopecs kopecs marked this pull request as ready for review January 15, 2025 18:24
@kopecs kopecs requested a review from ajbt200128 January 15, 2025 18:24
@kopecs
Copy link
Contributor Author

kopecs commented Jan 15, 2025

This should be responsive now that we updated the login flow.

Copy link
Contributor Author

kopecs commented Feb 6, 2025

Copy link
Contributor Author

kopecs commented Feb 6, 2025

Merge activity

  • Feb 6, 2:40 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Feb 6, 2:41 PM EST: Graphite rebased this pull request as part of a merge.
  • Feb 6, 2:42 PM EST: A user merged this pull request with Graphite.
  • Feb 6, 2:42 PM EST: Graphite couldn't merge this PR because it failed for an unknown reason.

This uses the new context key for login status.
@kopecs kopecs merged commit 984146f into develop Feb 6, 2025
8 of 10 checks passed
@kopecs kopecs deleted the cooper/code-7803 branch February 6, 2025 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants