Skip to content

Issue 52 implement the stix 21 windows service status enumeration #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

brett-heffelfinger
Copy link
Contributor

Closes #52

Need feedback/suggestions on the triples as they relate to the idea of enumeration, like in #103.

@uscholdm
Copy link
Contributor

uscholdm commented Jun 9, 2025

Closes #52

Need feedback/suggestions on the triples as they relate to the idea of enumeration, like in #103.

The values are not obviously or usefully ordered, so no need to use gist:sequence. Not sure if this is your question.

Copy link
Contributor

@uscholdm uscholdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IRI label mismatch.
'service' in IRI & label is redundant. Change all instances.

gist:WindowsServiceStatus
a owl:Class ;
rdfs:subClassOf gist:StixCategoryObject ;
skos:definition "A category describing Windows service statuses."^^xsd:string ;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
skos:definition "A category describing Windows service statuses."^^xsd:string ;
skos:definition "A category indicating the status of a Windows service."^^xsd:string ;

Comment on lines +2490 to +2496
gist:_WindowsServiceStatus_service-continue-pending
a gist:WindowsServiceStatus ;
skos:definition """STIX 2.1 description:
The service continue is pending."""^^xsd:string ;
skos:prefLabel "SERVICE_CONTINUE_PENDING"^^xsd:string ;
gist:stixTerm "SERVICE_CONTINUE_PENDING"^^xsd:string ;
.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IRI label mismatch.
'service' in IRI & label is redundant. Change all instances.

Suggested change
gist:_WindowsServiceStatus_service-continue-pending
a gist:WindowsServiceStatus ;
skos:definition """STIX 2.1 description:
The service continue is pending."""^^xsd:string ;
skos:prefLabel "SERVICE_CONTINUE_PENDING"^^xsd:string ;
gist:stixTerm "SERVICE_CONTINUE_PENDING"^^xsd:string ;
.
gist:_WindowsServiceStatus_continue-pending
a gist:WindowsServiceStatus ;
skos:definition """STIX 2.1 description:
The service continue is pending."""^^xsd:string ;
skos:prefLabel "continue pending"^^xsd:string ;
gist:stixTerm "SERVICE_CONTINUE_PENDING"^^xsd:string ;
.

@rhohimer rhohimer merged commit 4d4b0bc into develop Jun 11, 2025
@rhohimer rhohimer deleted the issue-52-implement-the-stix-21-windows-service-status-enumeration branch June 11, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement the STIX 2.1 Windows™ Service Status Enumeration
3 participants