Skip to content

Issue 50 implement the stix 21 windows service start type enumeration #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

brett-heffelfinger
Copy link
Contributor

Closes #50

Need feedback/suggestions on the triples as they relate to the idea of enumeration, like in #103.

@uscholdm
Copy link
Contributor

uscholdm commented Jun 9, 2025

Closes #50

Need feedback/suggestions on the triples as they relate to the idea of enumeration, like in #103.

The values are not ordered, so no need to use gist:sequence. Not sure if this is your question.

Copy link
Contributor

@uscholdm uscholdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IRI labels mismatched, no sequencing needed.

● Process (Windows Service extension)

An enumeration of Windows service start types."""^^xsd:string ;
skos:prefLabel "Windows™ Service Start Type Enumeration"^^xsd:string ;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IRI label mismatch

Suggested change
skos:prefLabel "Windows Service Start Type Enumeration"^^xsd:string ;
skos:prefLabel "Windows Service Start Type"^^xsd:string ;

a gist:WindowsServiceStartType ;
skos:definition """STIX 2.1 description:
A service started automatically by the service control manager during system startup."""^^xsd:string ;
skos:prefLabel "SERVICE_AUTO_START"^^xsd:string ;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IRI label mismatch. Fix all of the instances.

Suggested change
skos:prefLabel "SERVICE_AUTO_START"^^xsd:string ;
skos:prefLabel "service auto start"^^xsd:string ;

@rhohimer rhohimer merged commit 6459ba1 into develop Jun 11, 2025
@brett-heffelfinger brett-heffelfinger deleted the issue-50-implement-the-stix-21-windows-service-start-type-enumeration branch June 13, 2025 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement the STIX 2.1 Windows™ Service Start Type Enumeration
3 participants