-
Notifications
You must be signed in to change notification settings - Fork 18
GeoLocation #1203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
GeoLocation #1203
Conversation
Should I create the directory structure for migration/v14.0 ?? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ontology is fine.
Missing in release notes: removed restrictions on GeoSegment
- Remove deprecated class `gist:GeoSegmnet` Issue [#1182](https://github.com/semanticarts/gist/issues/1182). | ||
- Remove deprecated class `gist:GeoSegmnet` Issue [#1182](https://github.com/semanticarts/gist/issues/1182). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deprecated classes are only removed for a major release - verify that this is for gist 14
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is for gist 14, but since are not releasing a 13.1 we should not refer to this as deprecated.
I would like to see a top-level bullet point for geo-related changes, with the individual changes as sub-bullets. We can put them all under major changes even though some are not major.
These should be in the past tense and there should be a period between sentences. E.g.:
- Changes to geo classes:
- Renamed `gist:Place` to `gist:GeoLocation`. Issue [#1197](https://github.com/semanticarts/gist/issues/1197).
- Changed superclass of `gist:GeoRoute` to `gist:OrderedCollection`. Issue [#1197](https://github.com/semanticarts/gist/issues/1197).
- Removed class `gist:GeoSegment` and redefined `gist:GeoRoute` as an ordered collection of `gist:GeoPoint`s. Issue [#1182](https://github.com/semanticarts/gist/issues/1182).
- Updated annotations. Issue [#1197](https://github.com/semanticarts/gist/issues/1197).
@@ -0,0 +1,17 @@ | |||
|
|||
### Major Updates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing: removed restrictions on GeoSegment
skos:prefLabel "Geo Location"^^xsd:string ; | ||
skos:scopeNote "A geo-location may be a geo-point, geo-region, or geo-volume."^^xsd:string ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these supposed to be hyphenated or separate words or single words? We should be consistent across the annotations. E.g., here the pref label should be "Geo-Location" if we decide on hyphenated versions.
- Remove deprecated class `gist:GeoSegmnet` Issue [#1182](https://github.com/semanticarts/gist/issues/1182). | ||
- Remove deprecated class `gist:GeoSegmnet` Issue [#1182](https://github.com/semanticarts/gist/issues/1182). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is for gist 14, but since are not releasing a 13.1 we should not refer to this as deprecated.
I would like to see a top-level bullet point for geo-related changes, with the individual changes as sub-bullets. We can put them all under major changes even though some are not major.
These should be in the past tense and there should be a period between sentences. E.g.:
- Changes to geo classes:
- Renamed `gist:Place` to `gist:GeoLocation`. Issue [#1197](https://github.com/semanticarts/gist/issues/1197).
- Changed superclass of `gist:GeoRoute` to `gist:OrderedCollection`. Issue [#1197](https://github.com/semanticarts/gist/issues/1197).
- Removed class `gist:GeoSegment` and redefined `gist:GeoRoute` as an ordered collection of `gist:GeoPoint`s. Issue [#1182](https://github.com/semanticarts/gist/issues/1182).
- Updated annotations. Issue [#1197](https://github.com/semanticarts/gist/issues/1197).
skos:editorialNote "See guidance on removing this term in the next major release at #1182."^^xsd:string ; | ||
skos:prefLabel "Geo Segment"^^xsd:string ; | ||
skos:scopeNote "A GeoSegment is also a GeoRoute (a short one)."^^xsd:string ; | ||
skos:scopeNote "A geo-route could describe a bus route by identifying the points where the bus stops. A geo-route could describe the boundary of a polygonal geo-region (it does not have to be a travelled route."^^xsd:string ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
skos:scopeNote "A geo-route could describe a bus route by identifying the points where the bus stops. A geo-route could describe the boundary of a polygonal geo-region (it does not have to be a travelled route."^^xsd:string ; | |
skos:scopeNote "A geo-route could describe a bus route by identifying the points where the bus stops. A geo-route could describe the boundary of a polygonal geo-region (it does not have to be a travelled route)."^^xsd:string ; |
Closes #1197
Closes #939
Closes #1084
Closes #1182
Release note identifies specific changes.
For migration, re-use v12.0 SPARQL: replace_renamed.rq and detect_renamed.rq (variants for default and ngraphs).