Merge pull request #4 from selmi-karim/develop

Develop
selmi-karim · May 30, 2020 · 7d0911e · 7d0911e
2 parents f62ec3d + c259e54
commit 7d0911e
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,10 @@
+## [1.1.1](https://github.com/selmi-karim/dice-similarity-coeff/compare/v1.1.0...v1.1.1) (2020-05-30)
+
+
+### Bug Fixes
+
+* check char strings ([4e52b05](https://github.com/selmi-karim/dice-similarity-coeff/commit/4e52b0594e747f8e99548b53c7b460d053baf273))
+
 # [1.1.0](https://github.com/selmi-karim/dice-similarity-coeff/compare/v1.0.3...v1.1.0) (2020-05-30)
 
 

diff --git a/index.js b/index.js
@@ -7,7 +7,7 @@ const twoStrings = (sa1, sa2) => {
   // Comparison should not check case or whitespace
   let s1 = sa1.replace(/\s/g, "").toLowerCase();
   let s2 = sa2.replace(/\s/g, "").toLowerCase();
-
+  if(s1.length === 1 || s2.length === 1) return Number(s1 === s2)
   const similarity_num = 2 * intersect(pairs(s1), pairs(s2)).length;
   const similarity_den = pairs(s1).length + pairs(s2).length;
   return similarity_num / similarity_den;

diff --git a/index.test.js b/index.test.js
@@ -2,7 +2,7 @@ const dsc = require("./index");
 
 /** Comparing 2 exact same strings returns 1 */
 test("matching two equal strings", () => {
-  expect(dsc.twoStrings("hello world", "hello world")).toBe(1);
+  expect(dsc.twoStrings("a", "a")).toBe(1);
 });
 
 /** Comparing 2 different strings returns ]0,1[ */

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "dice-similarity-coeff",
-  "version": "1.1.0",
+  "version": "1.1.1",
   "description": "Find similarity between two strings, based on Dice Similarity Coefficient DSC",
   "main": "index.js",
   "scripts": {