Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move dictionary to dedicated page #458

Open
wants to merge 4 commits into
base: prod
Choose a base branch
from
Open

Move dictionary to dedicated page #458

wants to merge 4 commits into from

Conversation

kkemple
Copy link
Collaborator

@kkemple kkemple commented May 20, 2022

Description

This PR contains work for moving the dictionary to a dedicated page. As a by-product of that, content has moved from the home page to more dedicated pages as well, and a basic navigation has been added.

Related Issue

#183

Motivation and Context

The goal is to open up the home page to speak more about the project and highlight important information about the project and supporting it.

How Has This Been Tested?

So far only locally on my machine and brief QA with @tatianamac

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@kkemple kkemple requested a review from tatianamac May 20, 2022 21:07
Copy link
Contributor

@jvbreen1 jvbreen1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not super familiar with Eleventy itself, but this looks good to me! I did leave one comment about the link for submitting PRs.

<div class="box">
<h2 class="sub-headline">Ways to help</h2>
<ol class="list">
<li>Submit words and definitions or contribute to our code base through <a href="https://github.com/tatianamac/selfdefined/pulls" rel="noreferrer">pull requests</a> or <a href="https://github.com/tatianamac/selfdefined/issues" rel="noreferrer">issues</a>. Start with our <a href="https://github.com/selfdefined/web-app/blob/prod/CONTRIBUTING.md" rel="noreferrer">contributing guidelines</a> and <a href="/documentation/">documentation</a>.</li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this link correct? I don't think the codebase is in Tatiana's personal github anymore, is it?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is correct. @kkemple Do you want to fix this in this PR? It’s not strictly in the scope of it, so we can fix this separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants