Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ObsPy: Add introduction and install instructions #54

Merged
merged 11 commits into from
Jan 1, 2021
Merged

ObsPy: Add introduction and install instructions #54

merged 11 commits into from
Jan 1, 2021

Conversation

core-man
Copy link
Member

#40

@core-man core-man marked this pull request as draft December 31, 2020 07:40
@github-actions
Copy link
Contributor

github-actions bot commented Dec 31, 2020 •
edited
Loading

This comment was written by the Continuous Documentation bot!

@core-man core-man added the new software Request tutorials for a new software label Dec 31, 2020
seisman
seisman reviewed Dec 31, 2020
View reviewed changes
source/obspy/introduction.rst Outdated Show resolved Hide resolved
source/obspy/introduction.rst Outdated Show resolved Hide resolved
source/obspy/introduction.rst Outdated Show resolved Hide resolved
source/obspy/install.rst Outdated Show resolved Hide resolved
@core-man core-man changed the title WIP ObsPy: Add introduction and install instructions ObsPy: Add introduction and install instructions Jan 1, 2021
@core-man core-man marked this pull request as ready for review January 1, 2021 12:42
@core-man core-man requested a review from seisman January 1, 2021 12:43
seisman
seisman reviewed Jan 1, 2021
View reviewed changes
source/obspy/install.rst Outdated Show resolved Hide resolved
source/obspy/install.rst Outdated Show resolved Hide resolved
@core-man core-man merged commit 9e452f7 into main Jan 1, 2021
@core-man core-man deleted the obspy branch January 1, 2021 15:09
@seisman
Copy link
Member

seisman commented Jan 1, 2021

@core-man When you merge a PR, you will see a long list of commits and some "Co-authored-by" lines. You can clean up the long commits history, but please leave the "Co-authored-by" lines to give the reviewers (who made suggestions) more credits.

See the difference between the latest two commits:

image

@core-man
Copy link
Member Author

core-man commented Jan 1, 2021

ggg~ If Co-authored-by several times, shall I only keep one?

@seisman
Copy link
Member

seisman commented Jan 1, 2021

ggg~ If Co-authored-by several times, shall I only keep one?

Yes, keeping one line for each reviewer.

@core-man
Copy link
Member Author

core-man commented Jan 1, 2021

ggg~ If Co-authored-by several times, shall I only keep one?

Yes, keeping one line for each reviewer.

Okay~ Sorry for that~

@seisman
Copy link
Member

seisman commented Jan 1, 2021

I don't care about that, but just in case some future reviewers want more credits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seisman seisman seisman approved these changes

Assignees
No one assigned
Labels
new software Request tutorials for a new software
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@core-man @seisman