Use Marshal and UnmarshalJSON for HexBytes #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jewei1997
commented
Jul 20, 2024
| @@ -69,3 +69,24 @@ func (bz HexBytes) Format(s fmt.State, verb rune) { | |||
| s.Write([]byte(fmt.Sprintf("%X", []byte(bz)))) | |||
| } | |||
| } | |||
|
|
|||
| func (bz HexBytes) MarshalJSON() ([]byte, error) { | |||
There was a problem hiding this comment.
We should treat this as an app-hash breaking change due to potentially wide-ranging impact.
jewei1997
changed the title
yzang2019
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Use MarshalJSON and UnMarshalJSON for HexBytes. This PR may have wide-ranging consequences, so it is best to treat this as an app-hash breaking change.
Testing performed to validate your change
existing unit tests.