Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make RPC timeout configurable #238

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Make RPC timeout configurable #238

merged 1 commit into from
Jun 24, 2024

Conversation

codchen
Copy link
Collaborator

@codchen codchen commented Jun 21, 2024

Describe your changes and provide context

Add a TimeoutRead config for RPC endpoints (read-only)

Testing performed to validate your change

@codchen codchen requested a review from yzang2019 June 21, 2024 03:38
Copy link

codecov bot commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 58.24%. Comparing base (8484212) to head (d1df601).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #238   +/-   ##
=======================================
  Coverage   58.24%   58.24%           
=======================================
  Files         249      249           
  Lines       34445    34450    +5     
=======================================
+ Hits        20061    20067    +6     
- Misses      12801    12802    +1     
+ Partials     1583     1581    -2     
Files Coverage Δ
config/config.go 63.11% <100.00%> (+0.13%) ⬆️
config/toml.go 51.35% <ø> (ø)
internal/rpc/core/env.go 18.46% <0.00%> (-0.29%) ⬇️

... and 20 files with indirect coverage changes

@codchen codchen merged commit fbf3097 into main Jun 24, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants