Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metrics for total txs bytes in mempool #237

Merged
merged 3 commits into from
Jul 2, 2024
Merged

Conversation

yzang2019
Copy link
Contributor

@yzang2019 yzang2019 commented Jun 18, 2024

Describe your changes and provide context

The current problem is that we are blind about what's the daily mempool total txs size in bytes, and we are not sure what would be a safe config value to set to limit the size of txs in mempool.

This PR address this concern by adding visibility to monitor total txs size in bytes in mempool.

Testing performed to validate your change

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 76.74419% with 10 lines in your changes missing coverage. Please review.

Project coverage is 58.29%. Comparing base (fbf3097) to head (8fbeecc).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #237      +/-   ##
==========================================
+ Coverage   58.24%   58.29%   +0.04%     
==========================================
  Files         249      249              
  Lines       34450    34468      +18     
==========================================
+ Hits        20067    20094      +27     
+ Misses      12800    12790      -10     
- Partials     1583     1584       +1     
Files Coverage Δ
internal/mempool/mempool.go 73.42% <91.66%> (+0.54%) ⬆️
internal/mempool/metrics.gen.go 16.09% <57.89%> (+0.23%) ⬆️

... and 17 files with indirect coverage changes

@yzang2019 yzang2019 merged commit 2568028 into main Jul 2, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants