Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty prevote latency metrics #154

Merged
merged 1 commit into from
Aug 18, 2023
Merged

Fix empty prevote latency metrics #154

merged 1 commit into from
Aug 18, 2023

Conversation

codchen
Copy link
Collaborator

@codchen codchen commented Aug 18, 2023

Describe your changes and provide context

The node would crash if there is no prevotes info for a previous round

https://linear.app/seilabs/issue/SEI-5251/tendermint-rpc-bug

Testing performed to validate your change

tested with block sync without round info

@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #154 (446fd45) into main (d6af34b) will decrease coverage by 0.30%.
Report is 2 commits behind head on main.
The diff coverage is 57.14%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #154      +/-   ##
==========================================
- Coverage   59.16%   58.86%   -0.30%     
==========================================
  Files         281      281              
  Lines       38797    38799       +2     
==========================================
- Hits        22954    22840     -114     
- Misses      14061    14164     +103     
- Partials     1782     1795      +13     
Files Changed Coverage Δ
internal/consensus/state.go 70.02% <57.14%> (-2.15%) ⬇️

... and 16 files with indirect coverage changes

@codchen codchen merged commit 30df41d into main Aug 18, 2023
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants