Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase evm-temp to main #392

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Rebase evm-temp to main #392

wants to merge 8 commits into from

Conversation

codchen
Copy link
Collaborator

@codchen codchen commented Jan 5, 2024

Describe your changes and provide context

rebase

Testing performed to validate your change

## Describe your changes and provide context
For EVM getProof endpoint, we'd need to call functions on the underlying
iavl store, so we'd need a way to expose the parent store from a cachekv

## Testing performed to validate your change
## Describe your changes and provide context
We need to make `TxIndex` available during dependency generation so that
we can derive the corresponding temporary intermediate account and
coinbase account for the message

## Testing performed to validate your change
- To avoid multiple deserialization, as well as adding cached values to
sdk.Tx
- Add new acl constants for evm subprefixes
- Add a new bank send method that doesn't automatically create accounts
unit tests & local sei integration
Integrate with pending txs:
- return `ResponseCheckTxV2`
- add a new field `PendingTxChecker` field in Context

integration with local sei
## Describe your changes and provide context

## Testing performed to validate your change
## Describe your changes and provide context
Add two new bank keeper functions that allow sub-usei (i.e. wei)
sending, where 1 usei = 10^12 wei:
```
SendCoinsAndWei(ctx sdk.Context, from sdk.AccAddress, to sdk.AccAddress, customEscrow sdk.AccAddress, denom string, amt sdk.Int, wei sdk.Int) error
GetWeiBalance(ctx sdk.Context, addr sdk.AccAddress) sdk.Int
```
Any usei that is split as a result of wei sending will be stored in an
escrow account, which can either be one that's specified by the caller
or a default global escrow module account.

## Testing performed to validate your change
unit test & local integration with sei-chain
## Describe your changes and provide context

## Testing performed to validate your change
- Adding an expiration handler callback that lets the mempool

- sei-protocol/sei-tendermint#179

- e2e testing with hardhat tests
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

Attention: 82 lines in your changes are missing coverage. Please review.

Comparison is base (31cfbd9) 54.80% compared to head (33c829f) 54.76%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #392      +/-   ##
==========================================
- Coverage   54.80%   54.76%   -0.04%     
==========================================
  Files         622      622              
  Lines       52168    52296     +128     
==========================================
+ Hits        28590    28642      +52     
- Misses      21495    21555      +60     
- Partials     2083     2099      +16     
Files Coverage Δ
store/cachekv/store.go 80.99% <100.00%> (+0.17%) ⬆️
types/accesscontrol/resource.go 0.00% <ø> (ø)
x/bank/types/key.go 35.13% <ø> (ø)
x/genutil/gentx.go 77.46% <100.00%> (ø)
server/mock/app.go 79.12% <57.14%> (-2.70%) ⬇️
x/accesscontrol/keeper/keeper.go 91.12% <50.00%> (-0.92%) ⬇️
x/bank/keeper/view.go 87.02% <72.72%> (-1.32%) ⬇️
simapp/app.go 66.25% <0.00%> (-0.33%) ⬇️
baseapp/test_helpers.go 53.19% <45.45%> (-5.79%) ⬇️
baseapp/abci.go 53.66% <52.63%> (-0.31%) ⬇️
... and 3 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants