Skip to content

Commit

Permalink
fix: apply strictNullCheck fix in analytics.js client (#46)
Browse files Browse the repository at this point in the history
This replicates the fix from: #43 in the `analytics.js` library, which was mistakenly left out of the previous PR.
  • Loading branch information
colinking authored Jan 25, 2019
1 parent 5a6ef07 commit fb368f6
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion examples/gen-js/js/analytics/generated/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export interface SegmentOptions {
AppsFlyer?: {
appsFlyerId: string;
};
[key: string]: boolean | { [key: string]: string };
[key: string]: boolean | { [key: string]: string } | undefined;
};
}

Expand Down
2 changes: 1 addition & 1 deletion examples/gen-js/ts/analytics/generated/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export interface SegmentOptions {
AppsFlyer?: {
appsFlyerId: string;
};
[key: string]: boolean | { [key: string]: string };
[key: string]: boolean | { [key: string]: string } | undefined;
};
}

Expand Down
2 changes: 1 addition & 1 deletion src/commands/gen-js/typescript.ts
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ export interface SegmentOptions {
AppsFlyer?: {
appsFlyerId: string
}
[key: string]: boolean | { [key: string]: string }
[key: string]: boolean | { [key: string]: string } | undefined
}
}`

Expand Down
2 changes: 1 addition & 1 deletion tests/commands/gen-js/__snapshots__/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export interface SegmentOptions {
AppsFlyer?: {
appsFlyerId: string;
};
[key: string]: boolean | { [key: string]: string };
[key: string]: boolean | { [key: string]: string } | undefined;
};
}

Expand Down

0 comments on commit fb368f6

Please sign in to comment.