Skip to content

Commit

Permalink
fix: all SegmentOptions should be optional (#50)
Browse files Browse the repository at this point in the history
  • Loading branch information
mshwery authored Jan 29, 2019
1 parent 0fe1b73 commit e332779
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 8 deletions.
4 changes: 2 additions & 2 deletions examples/gen-js/js/analytics/generated/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ export interface SegmentOptions {
* Selectivly filter destinations. By default all destinations are enabled.
* https://segment.com/docs/sources/website/analytics.js/#selecting-destinations
*/
integrations: {
integrations?: {
All?: boolean;
AppsFlyer?: {
appsFlyerId: string;
Expand All @@ -90,7 +90,7 @@ export interface SegmentOptions {
* A dictionary of extra context to attach to the call.
* https://segment.com/docs/spec/common/#context
*/
context: Context;
context?: Context;
}

export interface FeedViewed {
Expand Down
4 changes: 2 additions & 2 deletions examples/gen-js/ts/analytics/generated/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ export interface SegmentOptions {
* Selectivly filter destinations. By default all destinations are enabled.
* https://segment.com/docs/sources/website/analytics.js/#selecting-destinations
*/
integrations: {
integrations?: {
All?: boolean;
AppsFlyer?: {
appsFlyerId: string;
Expand All @@ -90,7 +90,7 @@ export interface SegmentOptions {
* A dictionary of extra context to attach to the call.
* https://segment.com/docs/spec/common/#context
*/
context: Context;
context?: Context;
}

export interface FeedViewed {
Expand Down
4 changes: 2 additions & 2 deletions src/commands/gen-js/typescript.ts
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ export interface SegmentOptions {
* Selectivly filter destinations. By default all destinations are enabled.
* https://segment.com/docs/sources/website/analytics.js/#selecting-destinations
*/
integrations: {
integrations?: {
All?: boolean
AppsFlyer?: {
appsFlyerId: string
Expand All @@ -180,7 +180,7 @@ export interface SegmentOptions {
* A dictionary of extra context to attach to the call.
* https://segment.com/docs/spec/common/#context
*/
context: Context
context?: Context
}`

/** Target language for a.js TypeScript Declarations */
Expand Down
4 changes: 2 additions & 2 deletions tests/commands/gen-js/__snapshots__/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ export interface SegmentOptions {
* Selectivly filter destinations. By default all destinations are enabled.
* https://segment.com/docs/sources/website/analytics.js/#selecting-destinations
*/
integrations: {
integrations?: {
All?: boolean;
AppsFlyer?: {
appsFlyerId: string;
Expand All @@ -90,7 +90,7 @@ export interface SegmentOptions {
* A dictionary of extra context to attach to the call.
* https://segment.com/docs/spec/common/#context
*/
context: Context;
context?: Context;
}

export interface The42_TerribleEventName3 {
Expand Down

0 comments on commit e332779

Please sign in to comment.