all: add Unix datagram support #169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinburkesegment
force-pushed
the
mx51-feature-clean
branch
2 times, most recently
from
4b1a0e6 to
16cde10
Compare
I tried updating #123 with ~50 commits but the diff got too messy. Easier to just add the changes on a new commit.
kevinburkesegment
force-pushed
the
mx51-feature-clean
branch
from
f0d9fb9 to
251d359
Compare
ABHINAV-SUREKA
approved these changes
Oct 9, 2024
kevinburkesegment
added a commit
that referenced
this pull request
Feb 21, 2025
This error was introduced in #169 - if you scroll to datadog/client.go in that pull request, you can see how it happens, the buffer should be set on both the datadog serializer and the underlying buffer.Buffer, but was only set on one of those. Unfortunate error, and I will try to perform more benchmark testing going forward.
kevinburkesegment
added a commit
that referenced
this pull request
Feb 21, 2025
Commit 251d359 introduced a regression that slowed stat write benchmarks by 2.5x on Linux and 1.5x on Mac. The regression was caused by small writes causing contention for a shared file descriptor. This error was introduced in #169 - if you scroll to datadog/client.go in that pull request, you can see how it happens, the buffer should be set on both the datadog serializer and the underlying buffer.Buffer, but was only set on one of those. Unfortunate error, and I will try to perform more benchmark testing going forward.
kevinburkesegment
added a commit
that referenced
this pull request
Feb 21, 2025
Commit 251d359 introduced a regression that slowed stat write benchmarks by 2.5x on Linux and 1.5x on Mac. The regression was caused by small writes causing contention for a shared file descriptor. This error was introduced in #169 - if you scroll to datadog/client.go in that pull request, you can see how it happens, the buffer should be set on both the datadog serializer and the underlying buffer.Buffer, but was only set on one of those. Unfortunate error, and I will try to perform more benchmark testing going forward.
kevinburkesegment
added a commit
that referenced
this pull request
Feb 21, 2025
Commit 251d359 introduced a regression that slowed stat write benchmarks by 2.5x on Linux and 1.5x on Mac. The regression was caused by small writes causing contention for a shared file descriptor. This error was introduced in #169 - if you scroll to datadog/client.go in that pull request, you can see how it happens, the buffer should be set on both the datadog serializer and the underlying buffer.Buffer, but was only set on one of those. Unfortunate error, and I will try to perform more benchmark testing going forward.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried updating #123 with ~50 commits but the diff got too messy. Easier to just add the changes on a new commit.