Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Returning error if received UnknownTopicOrPartition from readPartitions #1315

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: Returning error if received UnknownTopicOrPartition from readPartitions #1315

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions consumergroup.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1027,12 +1027,7 @@ func (cg *ConsumerGroup) assignTopicPartitions(conn coordinator, group joinGroup

topics := extractTopics(members)
partitions, err := conn.readPartitions(topics...)

// it's not a failure if the topic doesn't exist yet. it results in no
// assignments for the topic. this matches the behavior of the official
// clients: java, python, and librdkafka.
// a topic watcher can trigger a rebalance when the topic comes into being.
if err != nil && !errors.Is(err, UnknownTopicOrPartition) {
if err != nil {
return nil, err
}

Expand Down