Removing async code from file writes #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsneed
previously approved these changes
Aug 13, 2024
|
Can you put some comments in there about why you're doing xyz in various places and maybe reference back to a bug? Nice work! |
bsneed
approved these changes
Aug 13, 2024
| file.lockSync(FileLock.blockingExclusive); | ||
| file.setPositionSync(0); | ||
| file.writeFromSync(buffer); | ||
| file.truncateSync(buffer.length); |
There was a problem hiding this comment.
Thinking about security out-loud; I wonder if this leaves the file contents in memory or overwrites them with 0s.
didiergarcia
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing corrupt file removal to not fail init, and removing async code from file write that may be making file corruption more likely.