Add signals.find test (#1174)

segmentio · Oct 29, 2024 · 51167c0 · 51167c0
1 parent 9e6db28
commit 51167c0
Show file tree

Hide file tree

Showing 2 changed files with 37 additions and 9 deletions.
diff --git a/packages/signals/signals-integration-tests/src/tests/signals-vanilla/index-page.ts b/packages/signals/signals-integration-tests/src/tests/signals-vanilla/index-page.ts
@@ -23,15 +23,19 @@ export class IndexPage extends BasePage {
     return promiseTimeout(p, 2000, 'analytics.on("track") did not resolve')
   }
 
-  addUserDefinedSignal() {
-    return this.page.evaluate(() => {
-      window.signalsPlugin.addSignal({
-        type: 'userDefined',
-        data: {
-          foo: 'bar',
-        },
-      })
-    })
+  addUserDefinedSignal(data?: Record<string, unknown>) {
+    return this.page.evaluate(
+      (args) => {
+        window.signalsPlugin.addSignal({
+          type: 'userDefined',
+          data: {
+            foo: 'bar',
+            ...args.data,
+          },
+        })
+      },
+      { data }
+    )
   }
 
   async clickButton() {

diff --git a/packages/signals/signals-integration-tests/src/tests/signals-vanilla/signals-find.test.ts b/packages/signals/signals-integration-tests/src/tests/signals-vanilla/signals-find.test.ts
@@ -0,0 +1,24 @@
+import { test, expect } from '@playwright/test'
+import { IndexPage } from './index-page'
+
+const indexPage = new IndexPage()
+
+test('should find the most recent signal', async ({ page }) => {
+  const basicEdgeFn = `const processSignal = (signal) => {
+  if (signal.type === 'interaction' && signal.data.target.id === 'complex-button') {
+    const mostRecentSignal = signals.find(signal, 'userDefined')
+    if (mostRecentSignal.data.num === 2) {
+      analytics.track('correct signal found')
+    }
+  }
+}`
+
+  await indexPage.loadAndWait(page, basicEdgeFn)
+  const tapiFlush = indexPage.waitForTrackingApiFlush()
+  await indexPage.addUserDefinedSignal({ num: 1 })
+  await indexPage.addUserDefinedSignal({ num: 2 })
+  await indexPage.clickComplexButton()
+  await tapiFlush
+  const lastEvent = indexPage.trackingAPI.lastEvent()
+  expect(lastEvent.event).toEqual('correct signal found')
+})