[Sendgrid] - minor bug preventing dynamic field from working #2591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2591 +/- ##
==========================================
- Coverage 78.56% 78.54% -0.02%
==========================================
Files 1024 1024
Lines 18079 18083 +4
Branches 3405 3413 +8
==========================================
+ Hits 14203 14204 +1
- Misses 2742 2745 +3
Partials 1134 1134 ☔ View full report in Codecov by Sentry. |
nick-Ag
reviewed
Nov 13, 2024
| @@ -51,8 +52,14 @@ export async function dynamicTemplateData(request: RequestClient, payload: Paylo | |||
| throw new Error('Template ID Field required before Dynamic Template Data fields can be configured') | |||
| } | |||
|
|
|||
| const templateId = parseTemplateId(payload.template_id ?? '') | |||
|
|
|||
| if (templateId == null || !templateId.startsWith('d-')) { | |||
There was a problem hiding this comment.
should there be an additional || templateId === '' here?
nick-Ag
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sendgrid - fixing Dynamic dropdown bug
Testing
Tested locally. Action behind FF