-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Salesforce custom object external #2485
base: main
Are you sure you want to change the base?
Conversation
- Updating API version to 62.
hi @brennan - This is a Salesforce PR raised by an SA, so passing this PR on to you so it can be triaged. |
New required fields detectedWarning Your PR adds new required fields to an existing destination. Adding new required settings/mappings for a destination already in production requires updating existing customer destination configuration. Ignore this warning if this PR is for a new destination with no active customers in production. The following required fields were added in this PR:
Add these new fields as optional instead and assume default values in |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2485 +/- ##
=======================================
Coverage 77.99% 78.00%
=======================================
Files 991 992 +1
Lines 17383 17394 +11
Branches 3281 3281
=======================================
+ Hits 13558 13568 +10
- Misses 2737 2738 +1
Partials 1088 1088 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of comments. Can we also clean up the PR to only include the changes you made and not other syntax changes from other destinations.
Could you also include a testing doc or provide proof of the tests you ran to verify
This modification:
Testing