Skip to content

Commit

Permalink
don't use product version because can have strings use splited intege…
Browse files Browse the repository at this point in the history
…red version (if pass strings to manifest) the file is build but errors on runtime
  • Loading branch information
iaymerich committed Aug 28, 2018
1 parent 4ea866c commit 47c39d6
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions jbinary.go
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ var (
flagWinMajorVersion = flag.String("win-version-major", "1", "Windows Application Major version")
flagWinMinorVersion = flag.String("win-version-minor", "0", "Windows Application Minor version")
flagWinPatchVersion = flag.String("win-version-patch", "0", "Windows Application Patch version")
flagWinBuildVersion = flag.String("win-version-build", "0", "Windows Application Build version")
flagWinExecutionLevel = flag.String("win-invoker", "asInvoker", "Windows Invoker type asInvoker|requireAdministrator default(asInvoker)")
flagWinExecutionBehaviour = flag.String("win-execution-behaviour", "console", "Default behaviour to run app, in gui mode no console is shown but you can't execute by console or capture stdout, (console|gui) default(console)")
flagWinExecutionBehaviourConsoleArgs = flag.String("win-execution-enable-console-behaviour-args", "-console;-terminal", "Arguments that will force console mode in case of default behaviour gui, default (-console;-terminal)")
Expand Down Expand Up @@ -155,12 +156,11 @@ func generateManifestFile(srcPath string) (file *os.File, err error) {
log.Fatal("Cannot create file", err)
}
defer f.Close()

fmt.Fprintf(f, `<assembly xmlns="urn:schemas-microsoft-com:asm.v1" manifestVersion="1.0">
<assemblyIdentity
type="win32"
name="%s"
version="%s"
version="%s.%s.%s.%s"
processorArchitecture="IA64"/>
<trustInfo xmlns="urn:schemas-microsoft-com:asm.v3">
<security>
Expand All @@ -171,7 +171,7 @@ func generateManifestFile(srcPath string) (file *os.File, err error) {
</requestedPrivileges>
</security>
</trustInfo>
</assembly>`,*flagWinProductName,*flagWinProductVersion,*flagWinExecutionLevel)
</assembly>`,*flagWinProductName,*flagWinMajorVersion,*flagWinMinorVersion,*flagWinPatchVersion,*flagWinBuildVersion,*flagWinExecutionLevel)
return f,err
}

Expand Down

0 comments on commit 47c39d6

Please sign in to comment.