[WIP] Structured errors #267
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Verbose error messages are now constructed through the __str__ method. Error tuples still exist as an @Property for backwards compatibility
Codecov Report
@@ Coverage Diff @@
## dev #267 +/- ##
==========================================
+ Coverage 96.36% 96.81% +0.44%
==========================================
Files 17 17
Lines 2366 2603 +237
==========================================
+ Hits 2280 2520 +240
+ Misses 86 83 -3
Continue to review full report at Codecov.
|
hishnash
reviewed
Mar 28, 2019
| if not getattr(instance, '_getting_validated', True): | ||
| instance._error_hook(self.error_tuples) #pylint: disable=protected-access | ||
|
|
||
| def __str__(self, tab=1, prefix='- '): |
There was a problem hiding this comment.
I would suggest __unicode__ and having a __str__ stub that returns the str version of the __unicode__
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work is in response to comments here: #263