Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Parent PR] Pyo3 bindings for omf-rust #7

Closed
wants to merge 157 commits into from
Closed

[Parent PR] Pyo3 bindings for omf-rust #7

wants to merge 157 commits into from

Conversation

antbrown
Copy link

Using this PR to collect together different streams of work that will form the pyo3 bindings for omf-rust.

Ant Brown and others added 30 commits September 12, 2024 07:58
Simple Python bindings for reading an OMF file via Rust
b770df7
Add maturin github action to build cross platform artifacts
22f122b
Fix up deprecated references
5629788
Rename Python workflow to Python (instead ofCI)
8a0a7ea
Need to add more instructions for other platforms (win/mac)
fe1cc36
Add testing-pyo3-bindings to branches to build Python bindings for
6e11235
comment out release job for now
3ac4f83
finish moving python bindings to its own directory
31ec161
cargo formatting (cargo fmt --all)
90b259d
set default working directory for building python bindings
50c0731
Start implementing Element, Geometry, PointSet and Project
e03cd0e
@andrew-catalyst
Only build current required linux and windows targets
586468f
@antbrown
Merge pull request #1 from david-drummond-bentley/CENPLAT-23813-speci…
526db50 
…fic-builds

Only build current required linux and windows targets
Wrap detect_open so we can detect if file is OMFv1
d81a949
Match Geometry::type_name
837ae56
Don't clone self.version
6260e5e
cargo fmt --all
3cafe16
Add PyIOError to use statements
cbbde31
@andrew-catalyst
Add first python binding test
2a76a97 
Run python tests on CI. Currently just on linux build
Split Reader up so it can raise a file io error separately
b6b9fa6
Change function name to is_omf1()
a6d5a07
@andrew-catalyst
Merge pull request #4 from david-drummond-bentley/omf-detect-omf1
e6c00c9 
Omf detect omf1
@andrew-catalyst
Use assertRaises()
cea497f
@andrew-catalyst
Merge pull request #3 from david-drummond-bentley/CENPLAT-23813-add-p…
679e878 
…ytest

Add first python binding test
Add get_vertices to PointSet
3434660
Add more getters to Project
25aab12
@andrew-catalyst
Add first python binding test
ac6106b 
Run python tests on CI. Currently just on linux build
Split Reader up so it can raise a file io error separately
d4098af
@andrew-catalyst
Use assertRaises()
c47edeb
Merge branch 'testing-pyo3-bindings' into CENPLAT-23913
95364e3
antbrown and others added 28 commits September 27, 2024 14:05
@antbrown
Merge pull request #22 from seequent/CENPLAT-24001-attribute-data-var…
1e625f8 
…iant-number-colormap

Add NumberColormap and Reader::array_boundaries
@jsutton24 @andrew-catalyst
Fix typo
26b6e5e
@jsutton24 @andrew-catalyst
Add OmfException type
a4b9672
@jsutton24 @andrew-catalyst
Add a couple of more specific exception types
84b0c18
@andrew-catalyst
Handle file open error
efe111f
@andrew-catalyst
Make all exceptions thrown by the python bindings derive from OmfExce…
cd02f1b 
…ption

Add additional OmfException types
@andrew-catalyst
Include problem detail in validation error exception
feea977
@andrew-catalyst
Generate test OMF files with a missing parquet and duplicate element …
d3a763e 
…name
@andrew-catalyst
Merge pull request #25 from seequent/CENPLAT-24064-omf-exception
76de36d 
Map rust exceptions to OmfException
@andrew-catalyst
Add OmfInvalidDataException and test
f123dcf
@andrew-catalyst
Merge pull request #26 from seequent/CENPLAT-24064-omf-invalid-data-e…
866ceda 
…xception

Add OmfInvalidDataException and test
@jsutton24
omf-python: Remove stray comment
24a883d
@jsutton24
Add missing word to error message
372de2d
@jsutton24
omf-python: Register some more Python classes
1469f7a
@jsutton24
omf-python: Add bindings for GridSurface
f6f0111
@jsutton24
omf-python: Add tests for GridSurface bindings
eef5931
@andrew-catalyst
Merge pull request #27 from seequent/CENPLAT-24002
3578702 
[CENPLAT-24002] Add Python bindings for GridSurface
@andrew-catalyst
Make attribute location in python bindings an enum
96a2a92
@andrew-catalyst
Add version number to python bindings
8a5b451
@andrew-catalyst
Merge pull request #28 from seequent/CENPLAT-23687-attribute-location…
4baebff 
…-enum

Make attribute location in python bindings an enum
@andrew-catalyst
Add python binding for element metadata
1dcc0c9 
Use serde-pyobject to convert metadata to python

Change attribute to also use this approach for metadata

Remove unused data_json method
@andrew-catalyst
Fix deprecation warning after updating pyo3
535735e
@andrew-catalyst
Update version number and remove duplicate in pyproject.toml
bbfba8a
@andrew-catalyst
Use OmfJsonException for metadata serialization errors
461bfe3
@andrew-catalyst
Merge pull request #30 from seequent/CENPLAT-24401-element-metadata
0c7e893 
Add python binding for element metadata
@andrew-catalyst
Add python bindings Block Model geometry type
688211a 
Rename Grid2 python classes to distinguish from Grid3 classes
@andrew-catalyst
Change to allow getting the mode and count for regular subblocks
a0eca3e
@andrew-catalyst
Merge pull request #32 from seequent/CENPLAT-24423-python-block-model…
940dc39 
…-bindings

Add python bindings Block Model geometry type
@jsutton24
Copy link

Closing in favour of #31.

@jsutton24 jsutton24 closed this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@antbrown @jsutton24 @andrew-catalyst @GaryWL @zinovya @Gary-Lockyer