Changes to HCI.py to support TI WL1837 module #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TI WL1837 Wi-Fi & Bluetooth module does not require the mac address bytes to be reversed when setting them, and the OpCode Command Field for setting the mac address is 0x006, not 0x001 (reference here). While making options for adding the ability to change the OpCode Group Field and control whether to restart the bluetooth daemon.
Running the HCI.py script as before with
sudo python3 HCI.py --key <ADVERTISMENT_KEY>behaves the same as it does in main when the new options are not specified. I've updated the README.md to reflect these changes.Successful location of my device with your app:
