Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include observation units in the statistics dashboards #2126

Merged
merged 3 commits into from
Jan 30, 2025

Conversation

stuzart
Copy link
Member

@stuzart stuzart commented Jan 29, 2025

added to the standard, project and programme dashboards

@stuzart stuzart requested a review from fbacall January 29, 2025 11:10
@stuzart stuzart added this to the 1.16.1 milestone Jan 29, 2025
@fbacall
Copy link
Contributor

fbacall commented Jan 30, 2025

Could also add a colour for them:

NEW_FILL_COLOURS = {
'Programme' => '#90A8FF',
'Project' => '#85D6FF',
'Investigation' => '#D6FF00',
'Study' => '#96ED29',
'Assay' =>'#52D155',
'Publication' => '#CBB8FF',
'DataFile' => '#FFC382',
'Document' => '#D5C8A8',
'Model' => '#F9EB57',
'Sop' => '#CCE5FF',
'Sample' => '#FFF2D5',
'Presentation' => '#FFB2E4',
'Event' => '#FF918E',
'Workflow' => '#ADCDDC',
'Collection' => '#ABEACB',
'HiddenItem' => '#D3D3D3'
}

@stuzart
Copy link
Member Author

stuzart commented Jan 30, 2025

Could also add a colour for them:

NEW_FILL_COLOURS = {
'Programme' => '#90A8FF',
'Project' => '#85D6FF',
'Investigation' => '#D6FF00',
'Study' => '#96ED29',
'Assay' =>'#52D155',
'Publication' => '#CBB8FF',
'DataFile' => '#FFC382',
'Document' => '#D5C8A8',
'Model' => '#F9EB57',
'Sop' => '#CCE5FF',
'Sample' => '#FFF2D5',
'Presentation' => '#FFB2E4',
'Event' => '#FF918E',
'Workflow' => '#ADCDDC',
'Collection' => '#ABEACB',
'HiddenItem' => '#D3D3D3'
}

Thanks. A blue ecolour is applied and I assumed it was picking this up from a colour I'd configured for the ISA graph previously. But looks like I'd done neither and blue is just the default. I will update this before merging.

slightly darker green, in line with the green theme for ISA objects
@stuzart stuzart merged commit f8bd466 into seek-1.16 Jan 30, 2025
19 checks passed
@stuzart stuzart deleted the obs-unit-dashboard-2122 branch January 30, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants