Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Use explicit ipv4 address instead of localhost when waiting on URLs #763

Merged
merged 1 commit into from
Apr 11, 2023
Merged

test: Use explicit ipv4 address instead of localhost when waiting on URLs #763

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion test-utils/waitForUrls.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,13 @@ const waitForUrls = async (...urls) => {

try {
return await waitOnAsync({
resources: urls.map((url) => url.replace(/http(s?)\:/, 'http$1-get:')),
resources: urls.map((url) =>
url
.replace(/http(s?)\:/, 'http$1-get:')
// As of node 17, ipv6 is preferred, so explicitly use ipv4
// See https://github.com/jeffbski/wait-on/issues/133
.replace(/localhost/, '127.0.0.1'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it work with this?

Suggested change
.replace(/localhost/, '127.0.0.1'),
.replace(/localhost/, '0.0.0.0'),

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in #764

),
headers: { accept: 'text/html, application/javascript' },
timeout,
// Log output of wait behaviour timing to allow
Expand Down