-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add vite build
command
#1183
add vite build
command
#1183
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
packages/sku/src/services/vite/helpers/cleanup/cleanupSsgBuild.ts
Outdated
Show resolved
Hide resolved
This is the same behavior as the multiple-routes fixture. It does the same thing so maybe we need to have a look at both of those. Also, currently the collector only gets all of the files from the manifest and doesn't do anything with lazy loading yet. The CollectorContext and plugin are still missing. I'm only using it to inject the correct scripts in the index.html from manifest. I'll add lazy loading and the corresponding plugin in as a separate pr. |
NVM, that's just how that fixture (and the vite one) are configured. On the NZ domain |
Add
build
command to the set of vite experimental commands.build
will use theroutes
object in thesku.config.ts
to build out the static sites for those routes.This can be tested by running
build
in thevite-test-app
fixture and runningserve
afterwards to test it.serve
is still using the original serve method fromsku
.This does not yet support full lazy loading which will come in a future pr.