Fix webp and avif support, test asset loading in fixture
#1181
+89
−104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 594d09e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jahredhope
approved these changes
Feb 21, 2025
Merged
DanDroryAu
reviewed
Feb 21, 2025
| @@ -27,7 +27,7 @@ export default jestDecorator({ | |||
| ], | |||
| moduleFileExtensions: ['js', 'json', 'ts', 'tsx'], | |||
| moduleNameMapper: { | |||
| '\\.(jpg|jpeg|png|gif|eot|otf|webp|svg|ttf|woff|woff2|mp4|webm|wav|mp3|m4a|aac|oga|svg)$': | |||
| '\\.(jpg|jpeg|png|gif|eot|otf|webp|svg|ttf|woff|woff2|mp4|webm|wav|mp3|m4a|aac|oga|svg|avif)$': | |||
There was a problem hiding this comment.
Question: Should bmp be in here as well?
Is it ok to load a bmp without a filemock?
There was a problem hiding this comment.
Oh, didn't notice that it was missing. Automerge beat you to it. I'll make another PR.
There was a problem hiding this comment.
I'll ✅ that when it shows up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like some changes from #1119 got missed when the change was merged into the v14 branch, so webpack currently fails to load
webpandavifimages.I've added the missing changes, as well
avifsupport for the jest file mock. Additionally, each supported image format is now tested within thepublic-pathfixture.